Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DIDResolution header changes [DEV-4721] #336

Merged
merged 33 commits into from
Feb 19, 2025
Merged

feat: DIDResolution header changes [DEV-4721] #336

merged 33 commits into from
Feb 19, 2025

Conversation

sownak
Copy link
Contributor

@sownak sownak commented Feb 11, 2025

  • new GetPriorityContentType to get prioritized acceptHeader (uses "github.com/timewasted/go-accept-headers" package)
  • handles DID Doc only, no DIDDoc metadata for application/did+json, application/did, application/did+ld+json
  • handles full resolution for / and application/ld+json;profile="https://w3id.org/did-resolution"
  • Moved /metadata route to diddoc/routes

@sownak sownak marked this pull request as draft February 11, 2025 17:53
@sownak sownak force-pushed the feat/header-option-did branch 2 times, most recently from 8a6d333 to 3905a85 Compare February 12, 2025 17:26
ankurdotb
ankurdotb requested changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR reviews should be requested when:

  1. Tests are not failing (they currently seem to be failing)
  2. PR is not set to draft (that automatically means it's still being worked on)...unless the intention is to ask for a WIP review?

DaevMithran
DaevMithran reviewed Feb 13, 2025
View reviewed changes
@sownak sownak force-pushed the feat/header-option-did branch from 3905a85 to 9713b6f Compare February 13, 2025 19:08
@sownak
feat: new headers for didDoc resolution
718149a 
Signed-off-by: Sownak Roy <sownak@cheqd.io>
@sownak sownak force-pushed the feat/header-option-did branch from a4fcc08 to 718149a Compare February 14, 2025 18:31
@sownak sownak changed the title feat: DIDResolution header changes feat: DIDResolution header changes [DEV-4721] Feb 14, 2025
@ankurdotb
Copy link
Contributor

Task linked: DEV-4721 Apply Accept header logic for DID Resolution

@sownak
Copy link
Contributor Author

sownak commented Feb 14, 2025

@ankurdotb This is a draft PR. The Integration tests are in progress mainly.
The rest can be reviewed with Focus on
services/diddoc/echo_handlers.go

sownak and others added 2 commits February 14, 2025 18:36
@sownak
fix: lint errors
42bd964 
Signed-off-by: Sownak Roy <sownak@cheqd.io>
@DaevMithran
Use go-accept-headers
30857d7
@sownak
Copy link
Contributor Author

sownak commented Feb 17, 2025

@ankurdotb this PR is ready for review, it also contains @DaevMithran's changes.

@DaevMithran I have modified your resource/metadata code and related testcases, when /metadata or correct profile is asked, we do not have to return the dereferencingMetadata.contentType as the resource's contentType.

@sownak
Copy link
Contributor Author

sownak commented Feb 17, 2025

Definitely this is now a big PR because the default has been updated in the testcases. Also, I will keep on adding more testcases

@DaevMithran
Copy link
Contributor

Definitely this is now a big PR because the default has been updated in the testcases. Also, I will keep on adding more testcases

@sownak can we target this PR to DEV-4722. So that it's easier to review

@DaevMithran DaevMithran changed the base branch from develop to DEV-4722 February 17, 2025 17:07
@ankurdotb
Copy link
Contributor

Task linked: DEV-4722 Apply Accept header logic for DID URL Dereferencing

@sownak
updated GetPriorityContentType
9baae4d 
Signed-off-by: Sownak Roy <sownak@cheqd.io>
@DaevMithran DaevMithran force-pushed the feat/header-option-did branch from 8c17718 to 1a3f2c8 Compare February 18, 2025 13:02
@sownak
fixed browser errors
a612dbe 
Signed-off-by: Sownak Roy <sownak@cheqd.io>
@sownak
updated dependabot changes
e7d4a09 
Signed-off-by: Sownak Roy <sownak@cheqd.io>
@sownak
added testcases
2cb17c3 
Signed-off-by: Sownak Roy <sownak@cheqd.io>
@sownak
Added Chrome test cases
ccdc750 
Signed-off-by: Sownak Roy <sownak@cheqd.io>
ankurdotb
ankurdotb requested changes Feb 19, 2025
View reviewed changes
@sownak
Updated with review comments
9bf680c 
Signed-off-by: Sownak Roy <sownak@cheqd.io>
@sownak
Updated with review comments
4670264 
Signed-off-by: Sownak Roy <sownak@cheqd.io>
@sownak sownak changed the base branch from DEV-4722 to develop February 19, 2025 15:54
@ankurdotb ankurdotb merged commit 3ea950b into develop Feb 19, 2025
16 of 17 checks passed
@ankurdotb ankurdotb deleted the feat/header-option-did branch February 19, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankurdotb ankurdotb ankurdotb requested changes

@DaevMithran DaevMithran DaevMithran left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sownak @ankurdotb @DaevMithran @Eengineer1